[WIP] feat: consolidate all YAML conditionals #891
+14,370
−5,404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThinkOpenly
reviewed
Jul 16, 2025
Comment on lines
+49
to
+50
| The "compatible with" operator will accept any version that is greater than or equal to the target and that has not been marked as a breaking version change in the database. | ||
| Note that RISC-V does not follow semantic versioning, so `2.0` may be compatible with `1.0` for a given extension as long as `2.0` (or any version between `1.0` and `2.0`) is not marked as a breaking version. |
There was a problem hiding this comment.
Is this "marking" documented somewhere?
If so, can you put a reference to that here?
ThinkOpenly
reviewed
Jul 16, 2025
Comment on lines
+102
to
+103
| | `less_than_or_equal` | Parameter value is less than or equal to | `less_than`: 5 | ||
| | `greater_than_or_equal` | Parameter value is greater than or equal to | `greater_than`: 5 |
There was a problem hiding this comment.
The examples here need to use the respective keys. (Looks like they were just copied from the previous examples.
ThinkOpenly
reviewed
Jul 16, 2025
| Generic constraints provide an escape hatch when a condition is difficult to express when using <<ext_reqs,Extension Requirements>> or <<param_reqs,Parameter Requirements>>. | ||
| A generic constraint is an IDL function containing one or more link:../idl.adoc#implications[implications]. | ||
| The constraint holds if all the implications are true. | ||
| The constraint function does not return a value. |
There was a problem hiding this comment.
It seems more logical to return a boolean, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP